Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-4340: Don't render RECAPTCHA if key isn't available #748

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

camillevilla
Copy link
Collaborator

@camillevilla camillevilla commented Dec 8, 2023

JIRA issue link

DM-4340

Description - what does this code do?

  • small follow up to DM-4340 to get tests that involve email forms passing. This only affects local dev and testing.

Testing done - how did you test it/steps on how can another person can test it

  1. Make sure that RECAPTCHA_SITE_KEY_V3 is not present in your local .env file.
  2. On master, start local dev and navigate to About.
  3. You should receive the error Recaptcha::RecaptchaError in About#index No site key specified.
  4. Check out this branch. Restart your server and navigate to the About page. The form should still render. Check the inspector and confirm that no recaptcha snippet is loaded.

@camillevilla
Copy link
Collaborator Author

Closing this PR since we'll be removing the relevant form.

@camillevilla camillevilla merged commit 88c91c1 into master Dec 11, 2023
5 of 7 checks passed
@camillevilla camillevilla deleted the dm-4340 branch December 11, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants